Introduce multi-module Maven project with JDBC Driver and JDBC gRPC modules#19
Merged
KaviarasuSakthivadivel merged 10 commits intomainfrom Feb 21, 2025
Merged
Conversation
KaviarasuSakthivadivel
force-pushed
the
ksakthivadivel-extract-proto-module
branch
4 times, most recently
from
9062fe7 to
4f34c7f
Compare
KaviarasuSakthivadivel
force-pushed
the
ksakthivadivel-extract-proto-module
branch
from
4f34c7f to
a54673a
Compare
mkaufmann
reviewed
Feb 14, 2025
…protoc generation in a different module.
# Conflicts: # jdbc-driver/src/test/java/com/salesforce/datacloud/jdbc/core/JDBCLimitsTest.java
mkaufmann
reviewed
Feb 18, 2025
mkaufmann
previously approved these changes
Feb 20, 2025
mkaufmann
previously approved these changes
Feb 20, 2025
mkaufmann
approved these changes
Feb 21, 2025
KaviarasuSakthivadivel
deleted the
ksakthivadivel-extract-proto-module
branch
jschneidereit
added a commit
that referenced
this pull request
Feb 27, 2025
- Manually implemented `StreamingResultSet::getType`, `StreamingResultSet::getConcurrency`, and `StreamingResultSet::getFetchDirection` methods to return appropriate values that match how `StreamingResultSet` works. - Moved a file into the `jdbc-slim` module that must have been missed during a subtle merge conflict in #19 - Added some more test coverage for row-based pagination, specifically for `DataCloudPreparedStatement`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor the project to implement a multi-module Maven structure, with the inclusion of two primary modules:
This change sets up a modular architecture to better organize the codebase and improve maintainability and scalability. Dependencies between modules are clearly defined.